----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/11335/#review21366 -----------------------------------------------------------
Patch looks good, apart from one comment. ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java <https://reviews.apache.org/r/11335/#comment44301> Apart from this change, all other changes are contained within if(isLocal) block. Because of this it seems its possible it might be triggered for non-local paths as well. Can you test it for hdfs:// path which has spaces. If its easy, it will be good to add it in test, else manual test is fine as well. - Ashutosh Chauhan On June 3, 2013, 10:18 p.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/11335/ > ----------------------------------------------------------- > > (Updated June 3, 2013, 10:18 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Description > ------- > > Patch includes fix and new test case. > > > This addresses bug HIVE-4554. > https://issues.apache.org/jira/browse/HIVE-4554 > > > Diffs > ----- > > data/files/person PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java > bd8d252 > ql/src/test/queries/clientpositive/load_file_with_space_in_the_name.q > PRE-CREATION > ql/src/test/results/clientpositive/load_file_with_space_in_the_name.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/11335/diff/ > > > Testing > ------- > > > Thanks, > > Xuefu Zhang > >
