> On June 3, 2013, 11:15 p.m., Ashutosh Chauhan wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java, line 
> > 273
> > <https://reviews.apache.org/r/11335/diff/3/?file=300140#file300140line273>
> >
> >     Apart from this change, all other changes are contained within 
> > if(isLocal) block. Because of this it seems its possible it might be 
> > triggered for non-local paths as well. Can you test it for hdfs:// path 
> > which has spaces. If its easy, it will be good to add it in test, else 
> > manual test is fine as well.

I tried to add a testcase loading file at HDFS into a table without a success. 
Doing this requires an HDFS accessible from the test machine. Please let me 
know if you think there is mechanism. However, I did manually test the case, 
and it works fine for me. (It fails w/o the patch.)


- Xuefu


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11335/#review21366
-----------------------------------------------------------


On June 3, 2013, 10:18 p.m., Xuefu Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11335/
> -----------------------------------------------------------
> 
> (Updated June 3, 2013, 10:18 p.m.)
> 
> 
> Review request for hive and Ashutosh Chauhan.
> 
> 
> Description
> -------
> 
> Patch includes fix and new test case.
> 
> 
> This addresses bug HIVE-4554.
>     https://issues.apache.org/jira/browse/HIVE-4554
> 
> 
> Diffs
> -----
> 
>   data/files/person PRE-CREATION 
>   ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java 
> bd8d252 
>   ql/src/test/queries/clientpositive/load_file_with_space_in_the_name.q 
> PRE-CREATION 
>   ql/src/test/results/clientpositive/load_file_with_space_in_the_name.q.out 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/11335/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Xuefu Zhang
> 
>

Reply via email to