[ https://issues.apache.org/jira/browse/HIVE-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13732741#comment-13732741 ]
Harish Butani commented on HIVE-4964: ------------------------------------- No just dead code removal. This code was handling: - the 'having clause' based filters we originally supported with windowing; - and also the use of 'lead/lag' udfs outside of UDAFs. We decided to remove support for these, if i recall, because: - associating having with windowing would be confusing to users. - lead/lag udf invocations when multiple partitioning are involved are ambiguous. In some cases it is not clear what order to evaluate the window expressions. We have already removed these features from the Semantic Analyzer. So they are not exposed to the user. This is a cleanup step of the Translator/PTFOperator that still had code to handle these cases. > Cleanup PTF code: remove code dealing with non standard sql behavior we had > original introduced > ----------------------------------------------------------------------------------------------- > > Key: HIVE-4964 > URL: https://issues.apache.org/jira/browse/HIVE-4964 > Project: Hive > Issue Type: Bug > Reporter: Harish Butani > Priority: Minor > Attachments: HIVE-4964.D11985.1.patch, HIVE-4964.D11985.2.patch > > > There are still pieces of code that deal with: > - supporting select expressions with Windowing > - supporting a filter with windowing > Need to do this before introducing Perf. improvements. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators For more information on JIRA, see: http://www.atlassian.com/software/jira