[ 
https://issues.apache.org/jira/browse/HIVE-4964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13749696#comment-13749696
 ] 

Edward Capriolo commented on HIVE-4964:
---------------------------------------

Also when possible avoid stack

{quote}
 Stack<PartitionedTableFunctionDef> fnDefs = new 
Stack<PartitionedTableFunctionDef>();
{quote}
instead use
{quote}
Deque d = new ArrayDeque()
{quote}

Stack is synchronized and has overhead. (i know some things in hive use stack 
already so this is sometimes unavoidable.
                
> Cleanup PTF code: remove code dealing with non standard sql behavior we had 
> original introduced
> -----------------------------------------------------------------------------------------------
>
>                 Key: HIVE-4964
>                 URL: https://issues.apache.org/jira/browse/HIVE-4964
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Harish Butani
>            Priority: Minor
>         Attachments: HIVE-4964.D11985.1.patch, HIVE-4964.D11985.2.patch
>
>
> There are still pieces of code that deal with:
> - supporting select expressions with Windowing
> - supporting a filter with windowing
> Need to do this before introducing  Perf. improvements. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Reply via email to