----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15308/#review28375 -----------------------------------------------------------
LGTM to me. Just two minor issues below. serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java <https://reviews.apache.org/r/15308/#comment55192> Can you remove these tabs? serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java <https://reviews.apache.org/r/15308/#comment55193> Thank you very much for fixing this error message! One nit, I think we should stick with an IllegalArgException as opposed to runtime since it looks more appropriate. - Brock Noland On Nov. 7, 2013, 3:14 p.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15308/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2013, 3:14 p.m.) > > > Review request for hive. > > > Bugs: HIVE-5564 > https://issues.apache.org/jira/browse/HIVE-5564 > > > Repository: hive-git > > > Description > ------- > > Patch addresses the missing precision/scale in the old metadata. It also put > costmatics on displayed column type for decimal on the console. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9a17c3c > ql/src/test/queries/clientpositive/decimal_1.q f8b3661 > ql/src/test/results/clientpositive/decimal_1.q.out 26cc4e2 > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java > 2982cf6 > > Diff: https://reviews.apache.org/r/15308/diff/ > > > Testing > ------- > > Manually tested. > > > Thanks, > > Xuefu Zhang > >
