> On Nov. 7, 2013, 7:20 p.m., Jason Dere wrote: > > ql/src/test/queries/clientpositive/decimal_1.q, line 5 > > <https://reviews.apache.org/r/15308/diff/1/?file=380431#file380431line5> > > > > I don't think this is actually able to test the scenario that you > > intend - this is going to test the fact that a newly created table with > > column type "decimal" will get translated to decimal(10,0), but this is > > because of the parser changes in your original decimal patch. So I don't > > think a qfile test is the right thing here - how about doing a JUnit to > > directly test the TypeInfoParser behavior? Using the example above you can > > test the typestring "decimal(4,2):decimal(5):decimal" and see if you get > > the correct TypeInfos back.
This is not mean to test the upgrade part. I manually tested that. Feel free to do so if you'd like. - Xuefu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/15308/#review28420 ----------------------------------------------------------- On Nov. 7, 2013, 3:14 p.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/15308/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2013, 3:14 p.m.) > > > Review request for hive. > > > Bugs: HIVE-5564 > https://issues.apache.org/jira/browse/HIVE-5564 > > > Repository: hive-git > > > Description > ------- > > Patch addresses the missing precision/scale in the old metadata. It also put > costmatics on displayed column type for decimal on the console. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java 9a17c3c > ql/src/test/queries/clientpositive/decimal_1.q f8b3661 > ql/src/test/results/clientpositive/decimal_1.q.out 26cc4e2 > serde/src/java/org/apache/hadoop/hive/serde2/typeinfo/TypeInfoUtils.java > 2982cf6 > > Diff: https://reviews.apache.org/r/15308/diff/ > > > Testing > ------- > > Manually tested. > > > Thanks, > > Xuefu Zhang > >
