-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16007/
-----------------------------------------------------------

Review request for hive.


Bugs: HIVE-5946
    https://issues.apache.org/jira/browse/HIVE-5946


Repository: hive-git


Description
-------

Moves the task creation logic to a factory which is now tested with 20 unit 
tests.


Diffs
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 
36503fa911161f5bca1b50182481a5a6ee38ae42 
  ql/src/java/org/apache/hadoop/hive/ql/exec/TaskFactory.java 
d0807d23de740ede9abe054aab946f043d6918b0 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
da80d817bb6e97db1d9a12e96a5c736ab2c3222b 
  ql/src/java/org/apache/hadoop/hive/ql/parse/DDLSemanticAnalyzer.java 
7443ea45cb1502090c1f6d03ce0c3b21d0bcaba4 
  
ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/AbstractHiveAuthorizationTaskFactory.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/DefaultHiveAuthorizationTaskFactory.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactory.java
 PRE-CREATION 
  
ql/src/java/org/apache/hadoop/hive/ql/parse/authorization/HiveAuthorizationTaskFactoryFactory.java
 PRE-CREATION 
  
ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/TestDefaultHiveAuthorizationTaskFactory.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/16007/diff/


Testing
-------

20 additional unit tests which pass


Thanks,

Brock Noland

Reply via email to