----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/18459/#review35452 -----------------------------------------------------------
trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java <https://reviews.apache.org/r/18459/#comment66000> Do you need to update hive-site template + test hive-site too? trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsAggregator.java <https://reviews.apache.org/r/18459/#comment65998> how does this work with task attempts? is there a chance of counting failed stuff? trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsPublisher.java <https://reviews.apache.org/r/18459/#comment65977> this would be easier to debug if the exception gets logged at a higher level (error/warn/exception) - multiple instances in both new files. - Gunther Hagleitner On Feb. 25, 2014, 8:09 a.m., Ashutosh Chauhan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/18459/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2014, 8:09 a.m.) > > > Review request for hive and Navis Ryu. > > > Bugs: HIVE-6500 > https://issues.apache.org/jira/browse/HIVE-6500 > > > Repository: hive > > > Description > ------- > > FS based stats collection. > > > Diffs > ----- > > trunk/common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java > 1571554 > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1571554 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java > 1571554 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1571554 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java > 1571554 > trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1571554 > trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > 1571554 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java > 1571554 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java > 1571554 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsPublisher.java > 1571554 > > trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsCollectionTaskIndependent.java > PRE-CREATION > trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsFactory.java 1571554 > trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsAggregator.java > PRE-CREATION > trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsPublisher.java > PRE-CREATION > trunk/ql/src/test/queries/clientpositive/statsfs.q PRE-CREATION > trunk/ql/src/test/results/clientpositive/statsfs.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/18459/diff/ > > > Testing > ------- > > Added new tests. > > > Thanks, > > Ashutosh Chauhan > >
