> On Feb. 25, 2014, 9:36 p.m., Gunther Hagleitner wrote:
> > trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java, line 626
> > <https://reviews.apache.org/r/18459/diff/1/?file=503283#file503283line626>
> >
> > Do you need to update hive-site template + test hive-site too?
The template file will be generated from HiveConf.java after HIVE-6037 gets
committed, so updating it would be wasted effort. But a parameter description
is needed, and it can go in a comment for now but once HIVE-6037 commits the
description has to be part of the parameter definition like this example:
CLIPROMPT("hive.cli.prompt", "hive",
"Command line prompt configuration value. Other hiveconf can be used in
this configuration value. \n" +
"Variable substitution will only be invoked at the Hive CLI startup."),
- Lefty
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18459/#review35452
-----------------------------------------------------------
On Feb. 25, 2014, 8:09 a.m., Ashutosh Chauhan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18459/
> -----------------------------------------------------------
>
> (Updated Feb. 25, 2014, 8:09 a.m.)
>
>
> Review request for hive and Navis Ryu.
>
>
> Bugs: HIVE-6500
> https://issues.apache.org/jira/browse/HIVE-6500
>
>
> Repository: hive
>
>
> Description
> -------
>
> FS based stats collection.
>
>
> Diffs
> -----
>
> trunk/common/src/java/org/apache/hadoop/hive/common/StatsSetupConst.java
> 1571554
> trunk/common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1571554
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java
> 1571554
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/StatsTask.java 1571554
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/TableScanOperator.java
> 1571554
> trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1571554
> trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
> 1571554
>
> trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregator.java
> 1571554
>
> trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsAggregatorTez.java
> 1571554
>
> trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/CounterStatsPublisher.java
> 1571554
>
> trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsCollectionTaskIndependent.java
> PRE-CREATION
> trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/StatsFactory.java 1571554
> trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsAggregator.java
> PRE-CREATION
> trunk/ql/src/java/org/apache/hadoop/hive/ql/stats/fs/FSStatsPublisher.java
> PRE-CREATION
> trunk/ql/src/test/queries/clientpositive/statsfs.q PRE-CREATION
> trunk/ql/src/test/results/clientpositive/statsfs.q.out PRE-CREATION
>
> Diff: https://reviews.apache.org/r/18459/diff/
>
>
> Testing
> -------
>
> Added new tests.
>
>
> Thanks,
>
> Ashutosh Chauhan
>
>
