[
https://issues.apache.org/jira/browse/HIVE-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14002222#comment-14002222
]
Xuefu Zhang commented on HIVE-7048:
-----------------------------------
[~swarnim] Thanks for your explanation.
CompositeHBaseKeyFactory is a concrete a class, so I'm expecting that it can do
something meaningful. While what you said makes sense, I don't understand why
CompositeHBaseKeyFactory is pushing down predicates at all. Also, why it
provides a validator that asserts that only the first field can be pushed down.
If it's doing this while not setting up corresponding filter, then the result
will not be correct. Therefore, I think there seems to be some inconsistency
here.
I'm fine to defer the implementation to the child class to do all these, but I
do think CompositeHBaseKeyFactory needs to be correct and consistent.
> CompositeKeyHBaseFactory should not use FamilyFilter
> ----------------------------------------------------
>
> Key: HIVE-7048
> URL: https://issues.apache.org/jira/browse/HIVE-7048
> Project: Hive
> Issue Type: Improvement
> Components: HBase Handler
> Reporter: Swarnim Kulkarni
> Assignee: Swarnim Kulkarni
> Priority: Blocker
> Attachments: HIVE-7048.1.patch.txt
>
>
> HIVE-6411 introduced a more generic way to provide composite key
> implementations via custom factory implementations. However it seems like the
> CompositeHBaseKeyFactory implementation uses a FamilyFilter for row key scans
> which doesn't seem appropriate. This should be investigated further and if
> possible replaced with a RowRangeScanFilter.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
