[ 
https://issues.apache.org/jira/browse/HIVE-7048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14004702#comment-14004702
 ] 

Xuefu Zhang commented on HIVE-7048:
-----------------------------------

We cannot make CompositeKeyHBaseFactory abstract as it's existing 
functionality: user provides a key class for HBase key via 
HBaseSerDe.HBASE_COMPOSITE_KEY_CLASS. However, without knowing how the key is 
serialized, CompositeKeyHBaseFactory is not able to do any pushdown. Thus, I 
think we should get rid of all pushdown/filter related code from 
CompositeKeyHBaseFactory. User desiring of this capability would have to 
provided their own key factory class. It's fine to extract the pushdown/filter 
related code into utility methods somewhere.

> CompositeKeyHBaseFactory should not use FamilyFilter
> ----------------------------------------------------
>
>                 Key: HIVE-7048
>                 URL: https://issues.apache.org/jira/browse/HIVE-7048
>             Project: Hive
>          Issue Type: Improvement
>          Components: HBase Handler
>            Reporter: Swarnim Kulkarni
>            Assignee: Swarnim Kulkarni
>            Priority: Blocker
>         Attachments: HIVE-7048.1.patch.txt
>
>
> HIVE-6411 introduced a more generic way to provide composite key 
> implementations via custom factory implementations. However it seems like the 
> CompositeHBaseKeyFactory implementation uses a FamilyFilter for row key scans 
> which doesn't seem appropriate. This should be investigated further and if 
> possible replaced with a RowRangeScanFilter.



--
This message was sent by Atlassian JIRA
(v6.2#6252)

Reply via email to