----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/22612/#review46143 -----------------------------------------------------------
serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveDecimal.java <https://reviews.apache.org/r/22612/#comment81374> Could you put this as a private static final class variable? - Xuefu Zhang On June 18, 2014, 9:06 p.m., Ashish Singh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/22612/ > ----------------------------------------------------------- > > (Updated June 18, 2014, 9:06 p.m.) > > > Review request for hive, Szehon Ho and Xuefu Zhang. > > > Bugs: HIVE-7234 > https://issues.apache.org/jira/browse/HIVE-7234 > > > Repository: hive-git > > > Description > ------- > > HIVE-7234: Handle nulls from decimal columns elegantly > > > Diffs > ----- > > data/files/decimal_10_0.txt PRE-CREATION > data/files/decimal_9_0.txt PRE-CREATION > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/TestDecimal.java > PRE-CREATION > ql/src/test/queries/clientpositive/decimal_10_0.q PRE-CREATION > ql/src/test/results/clientpositive/decimal_10_0.q.out PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyHiveDecimal.java > 78cc3819c61f5a1bcb0cdd3425a0105416c26861 > serde/src/java/org/apache/hadoop/hive/serde2/lazy/LazyUtils.java > 5a4623729ec955bbe8fcf662503b42ff8735eaad > > Diff: https://reviews.apache.org/r/22612/diff/ > > > Testing > ------- > > Added unit tests to test the scenario. > > > Thanks, > > Ashish Singh > >
