[
https://issues.apache.org/jira/browse/HIVE-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14062613#comment-14062613
]
David Chen commented on HIVE-7286:
----------------------------------
Hi Szehon,
Thank you for your feedback.
Yes, once HIVE-6806 is committed, we will be able to get rid of
StorageCustomHandler. However, since this patch has been complete and working
for quite some time now, I think it is better to push ahead and get this patch
in, even if HIVE-6806 has not been committed yet. Removing StorageCustomHandler
is easy to do, and I can open a separate ticket and do that once HIVE-6806 is
in. My main concern is that it is difficult to say when HIVE-6806 will be done
and committed, and I would rather not have this patch be blocked for too long
because it is blocking other HCatalog test work that I am doing.
I understand that the use of reflection in the test will make SerDe development
a bit more involved, but I think that it is, in fact, better if SerDe
development is made more rigorous. I think that ideally, all SerDes and
Input/OutputFormats in Hive should be accounted for by the set of
StorageFormatDescriptors in Hive. Otherwise, it will be increasingly difficult
to enforce a consistent code quality and test coverage for all available
storage formats supported by Hive.
> Parameterize HCatMapReduceTest for testing against all Hive storage formats
> ---------------------------------------------------------------------------
>
> Key: HIVE-7286
> URL: https://issues.apache.org/jira/browse/HIVE-7286
> Project: Hive
> Issue Type: Test
> Components: HCatalog
> Reporter: David Chen
> Assignee: David Chen
> Attachments: HIVE-7286.1.patch, HIVE-7286.2.patch, HIVE-7286.3.patch,
> HIVE-7286.4.patch
>
>
> Currently, HCatMapReduceTest, which is extended by the following test suites:
> * TestHCatDynamicPartitioned
> * TestHCatNonPartitioned
> * TestHCatPartitioned
> * TestHCatExternalDynamicPartitioned
> * TestHCatExternalNonPartitioned
> * TestHCatExternalPartitioned
> * TestHCatMutableDynamicPartitioned
> * TestHCatMutableNonPartitioned
> * TestHCatMutablePartitioned
> These tests run against RCFile. Currently, only TestHCatDynamicPartitioned is
> run against any other storage format (ORC).
> Ideally, HCatalog should be tested against all storage formats supported by
> Hive. The easiest way to accomplish this is to turn HCatMapReduceTest into a
> parameterized test fixture that enumerates all Hive storage formats. Until
> HIVE-5976 is implemented, we would need to manually create the mapping of
> SerDe to InputFormat and OutputFormat. This way, we can explicitly keep track
> of which storage formats currently work with HCatalog or which ones are
> untested or have test failures. The test fixture should also use Reflection
> to find all classes in the classpath that implements the SerDe interface and
> raise a failure if any of them are not enumerated.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
