[
https://issues.apache.org/jira/browse/HIVE-7286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14065867#comment-14065867
]
Szehon Ho commented on HIVE-7286:
---------------------------------
Thanks David. I'd rather have HIVE-6806 committed first if it shouldn't take
too long.
As for the classpath part, we are at a disagreement. I respect your desire to
make the Serde contract stricter, although I feel its a bigger topic than this
JIRA. But even if thats the decision, having an HCat test be the enforcer
seems strange. To me, its an illogical module to enforce that (should be in
Hive if thats the case), and prone to error (say if you end up in an
environment where the test's classpath is different).
> Parameterize HCatMapReduceTest for testing against all Hive storage formats
> ---------------------------------------------------------------------------
>
> Key: HIVE-7286
> URL: https://issues.apache.org/jira/browse/HIVE-7286
> Project: Hive
> Issue Type: Test
> Components: HCatalog
> Reporter: David Chen
> Assignee: David Chen
> Attachments: HIVE-7286.1.patch, HIVE-7286.2.patch, HIVE-7286.3.patch,
> HIVE-7286.4.patch
>
>
> Currently, HCatMapReduceTest, which is extended by the following test suites:
> * TestHCatDynamicPartitioned
> * TestHCatNonPartitioned
> * TestHCatPartitioned
> * TestHCatExternalDynamicPartitioned
> * TestHCatExternalNonPartitioned
> * TestHCatExternalPartitioned
> * TestHCatMutableDynamicPartitioned
> * TestHCatMutableNonPartitioned
> * TestHCatMutablePartitioned
> These tests run against RCFile. Currently, only TestHCatDynamicPartitioned is
> run against any other storage format (ORC).
> Ideally, HCatalog should be tested against all storage formats supported by
> Hive. The easiest way to accomplish this is to turn HCatMapReduceTest into a
> parameterized test fixture that enumerates all Hive storage formats. Until
> HIVE-5976 is implemented, we would need to manually create the mapping of
> SerDe to InputFormat and OutputFormat. This way, we can explicitly keep track
> of which storage formats currently work with HCatalog or which ones are
> untested or have test failures. The test fixture should also use Reflection
> to find all classes in the classpath that implements the SerDe interface and
> raise a failure if any of them are not enumerated.
--
This message was sent by Atlassian JIRA
(v6.2#6252)
