----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25047/#review51561 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/25047/#comment89965> Table object is invariant. We can do this outside of for loop. metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/25047/#comment89968> We dont need to do getMPartition() call, because all that is needed is just partition name in PART_COL_STATS table which we can already construct from request. - Ashutosh Chauhan On Aug. 26, 2014, 12:22 a.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25047/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 12:22 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > The previous solution https://issues.apache.org/jira/browse/HIVE-7736 > is not enough for the case when there are too many columns/partitions. > The user will encounter > org.apache.thrift.transport.TTransportException: > java.net.SocketTimeoutException: Read timed out > We try to remove more of transaction overhead > > > Diffs > ----- > > metastore/bin/.gitignore 0dd9890 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 06d7595 > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > 0693039 > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e435d69 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 3847d99 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 981fa1a > ql/.gitignore 916e17c > > Diff: https://reviews.apache.org/r/25047/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
