----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25047/#review51782 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/25047/#comment90383> You want to persist the object regardless whether it exists or not. Its update (if found) or insert scenario (if not found). So, Why do you need to retrieve MPartitionColumnStatistics? metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/25047/#comment90385> We want to update stats object in such case too. Will that be the case here ? metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java <https://reviews.apache.org/r/25047/#comment90386> Nested transactions are never a good idea. You are already in a txn, no need to create another one. - Ashutosh Chauhan On Aug. 27, 2014, 10:56 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/25047/ > ----------------------------------------------------------- > > (Updated Aug. 27, 2014, 10:56 p.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > The previous solution https://issues.apache.org/jira/browse/HIVE-7736 > is not enough for the case when there are too many columns/partitions. > The user will encounter > org.apache.thrift.transport.TTransportException: > java.net.SocketTimeoutException: Read timed out > We try to remove more of transaction overhead > > > Diffs > ----- > > metastore/bin/.gitignore 0dd9890 > metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java > 9e3481a > metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java > e8f16a5 > metastore/src/java/org/apache/hadoop/hive/metastore/RawStore.java e435d69 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreControlledCommit.java > 3847d99 > > metastore/src/test/org/apache/hadoop/hive/metastore/DummyRawStoreForJdoConnection.java > 981fa1a > ql/.gitignore 916e17c > > Diff: https://reviews.apache.org/r/25047/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
