> On Aug. 28, 2014, 8:02 a.m., Prasanth_J wrote: > > ql/src/test/queries/clientpositive/temp_table_display_colstats_tbllvl.q, > > line 1 > > <https://reviews.apache.org/r/24472/diff/1/?file=655372#file655372line1> > > > > Can you also add a testcase for partitioned table? similar to > > columnstats_partlvl.q > > Jason Dere wrote: > Not currently supporting partitioned temp tables. > > Prasanth_J wrote: > Will it throw an exception in that case? If so can you add a > NegativeCliDriver test just to make sure it throws some exception if used > with partitioned tables.
Yep, there is already clientnegative/temp_table_partitions.q - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51763 ----------------------------------------------------------- On Aug. 26, 2014, 6:37 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24472/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 6:37 p.m.) > > > Review request for hive and Prasanth_J. > > > Bugs: HIVE-7649 > https://issues.apache.org/jira/browse/HIVE-7649 > > > Repository: hive-git > > > Description > ------- > > Update SessionHiveMetastoreClient to get column stats to work for temp tables. > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > 5a56ced > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > 37b1669 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java > 24f3710 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java fcfcf42 > ql/src/test/queries/clientnegative/temp_table_column_stats.q 9b7aa4a > ql/src/test/queries/clientpositive/temp_table_display_colstats_tbllvl.q > PRE-CREATION > ql/src/test/results/clientnegative/temp_table_column_stats.q.out 4b0c0bc > ql/src/test/results/clientpositive/temp_table_display_colstats_tbllvl.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/24472/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
