> On Aug. 28, 2014, 7:56 a.m., Prasanth_J wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java, > > line 396 > > <https://reviews.apache.org/r/24472/diff/1/?file=655368#file655368line396> > > > > Is there any reason why you are not using FieldSchema's equals() here? > > Jason Dere wrote: > FieldSchema.equals() also compares the column comment, which could be > changed during alter table. If just the column comment changed the columns > are still relatively similar. > > Prasanth_J wrote: > Can you add equalsIgnoreComment() to FieldSchema then?
Unfortunately FieldSchema is a generated class based on the metastore Thrift definition file so we can't really do that. I can add that as a utility method somewhere but that's it. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/24472/#review51754 ----------------------------------------------------------- On Aug. 26, 2014, 6:37 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/24472/ > ----------------------------------------------------------- > > (Updated Aug. 26, 2014, 6:37 p.m.) > > > Review request for hive and Prasanth_J. > > > Bugs: HIVE-7649 > https://issues.apache.org/jira/browse/HIVE-7649 > > > Repository: hive-git > > > Description > ------- > > Update SessionHiveMetastoreClient to get column stats to work for temp tables. > > > Diffs > ----- > > metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java > 5a56ced > > ql/src/java/org/apache/hadoop/hive/ql/metadata/SessionHiveMetaStoreClient.java > 37b1669 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java > 24f3710 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java fcfcf42 > ql/src/test/queries/clientnegative/temp_table_column_stats.q 9b7aa4a > ql/src/test/queries/clientpositive/temp_table_display_colstats_tbllvl.q > PRE-CREATION > ql/src/test/results/clientnegative/temp_table_column_stats.q.out 4b0c0bc > ql/src/test/results/clientpositive/temp_table_display_colstats_tbllvl.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/24472/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
