[ 
https://issues.apache.org/jira/browse/HIVE-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14153450#comment-14153450
 ] 

Eugene Koifman commented on HIVE-8290:
--------------------------------------

There is unused import "hive_metastoreConstants".  Also, could you add a 
comment on ACID_TABLE_PROPERTY, basically the equivalent of the the Description 
of this Jira ticket?  

This is minor, but would it make sense to move the constant to AcidInputFormat 
or some other more directly ACID related class?

Otherwise, LGTM +1.

> With DbTxnManager configured, all ORC tables forced to be transactional
> -----------------------------------------------------------------------
>
>                 Key: HIVE-8290
>                 URL: https://issues.apache.org/jira/browse/HIVE-8290
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 0.14.0
>            Reporter: Alan Gates
>            Assignee: Alan Gates
>            Priority: Blocker
>             Fix For: 0.14.0
>
>         Attachments: HIVE-8290.2.patch, HIVE-8290.patch
>
>
> Currently, once a user configures DbTxnManager to the be transaction manager, 
> all tables that use ORC are expected to be transactional.  This means they 
> all have to have buckets.  This most likely won't be what users want.
> We need to add a specific mark to a table so that users can indicate it 
> should be treated in a transactional way.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to