> On Oct. 18, 2014, 5:34 p.m., Thejas Nair wrote: > > ql/src/test/results/clientpositive/show_functions.q.out, line 21 > > <https://reviews.apache.org/r/26854/diff/1/?file=723916#file723916line21> > > > > we need to document that windowing functions show up with "@_" prefix > > in 'show_functions' output > > Lefty Leverenz wrote: > Do you mean document in the wiki, or in javadocs? > > > https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL#LanguageManualDDL-ShowFunctions > > Lefty Leverenz wrote: > Also > https://cwiki.apache.org/confluence/display/Hive/LanguageManual+WindowingAndAnalytics.
I mean the wiki docs. You have very sharp eyes! I didn't think you would catch this review comment :) - Thejas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/26854/#review57232 ----------------------------------------------------------- On Oct. 17, 2014, 2:21 a.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/26854/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2014, 2:21 a.m.) > > > Review request for hive. > > > Bugs: HIVE-2573 > https://issues.apache.org/jira/browse/HIVE-2573 > > > Repository: hive-git > > > Description > ------- > > Small updates to Navis' changes: > - session registry doesn't lookup metastore for UDFs > - my feedback from Navis' original patch > - metastore udfs should not be considered native. This allows them to be > added/removed from registry > > > Diffs > ----- > > contrib/src/test/results/clientnegative/invalid_row_sequence.q.out 8f3c0b3 > contrib/src/test/results/clientpositive/udaf_example_max.q.out 82aeca7 > contrib/src/test/results/clientpositive/udaf_example_min.q.out b62ff39 > > itests/hive-unit/src/test/java/org/apache/hive/service/TestHiveServerSessions.java > PRE-CREATION > itests/util/src/main/java/org/apache/hadoop/hive/ql/QTestUtil.java a035ff1 > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 31978fe > ql/src/java/org/apache/hadoop/hive/ql/exec/CommonFunctionInfo.java 93c15c0 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionInfo.java 074255b > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java b94f790 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 569c125 > ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/WindowFunctionInfo.java efecb05 > ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java > 22e5b47 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java af633cb > ql/src/test/org/apache/hadoop/hive/ql/parse/TestMacroSemanticAnalyzer.java > 46f8052 > ql/src/test/queries/clientnegative/drop_native_udf.q ae047bb > ql/src/test/results/clientnegative/drop_native_udf.q.out 9f0eaa5 > ql/src/test/results/clientpositive/show_functions.q.out 944c567 > ql/src/test/results/clientpositive/udaf_collect_set.q.out 42f2d9d > ql/src/test/results/clientpositive/udaf_corr.q.out 1b468c4 > ql/src/test/results/clientpositive/udaf_covar_pop.q.out fa1d47e > ql/src/test/results/clientpositive/udaf_covar_samp.q.out ff5b47e > ql/src/test/results/clientpositive/udf_avg.q.out 7ac139f > ql/src/test/results/clientpositive/udf_count.q.out 78228ec > ql/src/test/results/clientpositive/udf_max.q.out 8535752 > ql/src/test/results/clientpositive/udf_min.q.out ca8158e > ql/src/test/results/clientpositive/udf_percentile.q.out b963236 > ql/src/test/results/clientpositive/udf_std.q.out c004157 > ql/src/test/results/clientpositive/udf_stddev.q.out 8948dfc > ql/src/test/results/clientpositive/udf_stddev_samp.q.out 6619ea1 > ql/src/test/results/clientpositive/udf_sum.q.out 2f4e3da > ql/src/test/results/clientpositive/udf_var_pop.q.out cd9c61e > ql/src/test/results/clientpositive/udf_var_samp.q.out 190435d > ql/src/test/results/clientpositive/udf_variance.q.out c00dd66 > service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java > fd38907 > > Diff: https://reviews.apache.org/r/26854/diff/ > > > Testing > ------- > > > Thanks, > > Jason Dere > >
