-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26854/
-----------------------------------------------------------
(Updated Oct. 20, 2014, 6:28 p.m.)
Review request for hive, Navis Ryu and Thejas Nair.
Changes
-------
Updating with Navis' changes - HIVE-2573.8.patch.txt - his description:
But one thing I want to change is that all functions in native registry should
be native function and vise versa to clarify function types. I think we can
define permanent function as a native function but acts as a temporary function
when accessed, by registering itself to session registry. So it's,
system registry (native) : builtin-function + permanent function (contains
definition only)
session register (non-native) : temporary function + permanent function
Bugs: HIVE-2573
https://issues.apache.org/jira/browse/HIVE-2573
Repository: hive-git
Description
-------
Small updates to Navis' changes:
- session registry doesn't lookup metastore for UDFs
- my feedback from Navis' original patch
- metastore udfs should not be considered native. This allows them to be
added/removed from registry
Diffs (updated)
-----
ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java 9ac540e
ql/src/java/org/apache/hadoop/hive/ql/exec/CommonFunctionInfo.java 93c15c0
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionInfo.java 074255b
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java b94f790
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 569c125
ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/exec/WindowFunctionInfo.java efecb05
ql/src/java/org/apache/hadoop/hive/ql/optimizer/optiq/translator/SqlFunctionConverter.java
31f906a
ql/src/java/org/apache/hadoop/hive/ql/optimizer/ppr/PartitionPruner.java
e43d39f
ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java
22e5b47
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java af633cb
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/MatchPath.java aa48a6c
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/Noop.java fcf6afd
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/NoopStreaming.java 41e0102
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/NoopWithMap.java 0b090a9
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/NoopWithMapStreaming.java
5d322d3
ql/src/java/org/apache/hadoop/hive/ql/udf/ptf/WindowingTableFunction.java
903a9b0
ql/src/test/org/apache/hadoop/hive/ql/parse/TestMacroSemanticAnalyzer.java
46f8052
ql/src/test/queries/clientnegative/drop_native_udf.q ae047bb
ql/src/test/results/clientnegative/create_function_nonexistent_class.q.out
c7405ed
ql/src/test/results/clientnegative/create_function_nonudf_class.q.out d0dd50a
ql/src/test/results/clientnegative/drop_native_udf.q.out 9f0eaa5
service/src/test/org/apache/hadoop/hive/service/TestHiveServerSessions.java
fd38907
Diff: https://reviews.apache.org/r/26854/diff/
Testing
-------
Thanks,
Jason Dere
