----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/27292/#review58872 -----------------------------------------------------------
shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java <https://reviews.apache.org/r/27292/#comment100030> just so i understand this: we will reload the config every time this method is called (from new session), right ? should we move the setReloadListner() call before allocsLoader.init() because reloadAllocations() is also called inside init(). In which case, we don't need to explicitly call allocsLoader.reloadAllocations(), right ? Also, do we really need to protect the config with AtomicReference ? shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java <https://reviews.apache.org/r/27292/#comment100024> nit: "Failed to load queue allocations file" - Mohit Sabharwal On Oct. 28, 2014, 5:48 p.m., Prasad Mujumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/27292/ > ----------------------------------------------------------- > > (Updated Oct. 28, 2014, 5:48 p.m.) > > > Review request for hive, Brock Noland and Mohit Sabharwal. > > > Bugs: HIVE-8634 > https://issues.apache.org/jira/browse/HIVE-8634 > > > Repository: hive-git > > > Description > ------- > > The fair scheduler queue refresh in HiveServer2 (for non-impersonation mode), > doesn't handle the primary/secondary queue mappings correctly. It's not > reading primary and secondary rules from the scheduler rule file. > The patch involves refreshing the queue policy allocation to read the > fair-scheduler.xml file correctly. > > > Diffs > ----- > > data/conf/fair-scheduler-test.xml PRE-CREATION > > itests/hive-unit-hadoop2/src/test/java/org/apache/hive/jdbc/TestSchedulerQueue.java > 79878ba > shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java > 6125714 > > Diff: https://reviews.apache.org/r/27292/diff/ > > > Testing > ------- > > Added test cases to for various queue allocation rules. > > > Thanks, > > Prasad Mujumdar > >
