-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/27292/#review59023
-----------------------------------------------------------

Ship it!


LGTM! Thank you Prasad! Some very minor items below, please update and then 
submit a new patch. I will +1 on JIRA.


data/conf/fair-scheduler-test.xml
<https://reviews.apache.org/r/27292/#comment100297>

    trim trailing ws



shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java
<https://reviews.apache.org/r/27292/#comment100299>

    Yeah let's make:
    
    throw new IOException("Failed to load queue allocations", ex);
    
    this:
    
    throw new IOException("Failed to load queue allocations file: " + ex, ex);
    
    the + ex gives the user (1) the name of the exception and (2) message all 
in the first error they see



shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java
<https://reviews.apache.org/r/27292/#comment100298>

    Based on the code, I don't think this should occur. If it does, should we 
put out a error message?


- Brock Noland


On Oct. 28, 2014, 5:48 p.m., Prasad Mujumdar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/27292/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2014, 5:48 p.m.)
> 
> 
> Review request for hive, Brock Noland and Mohit Sabharwal.
> 
> 
> Bugs: HIVE-8634
>     https://issues.apache.org/jira/browse/HIVE-8634
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> The fair scheduler queue refresh in HiveServer2 (for non-impersonation mode), 
> doesn't handle the primary/secondary queue mappings correctly. It's not 
> reading primary and secondary rules from the scheduler rule file.
> The patch involves refreshing the queue policy allocation to read the 
> fair-scheduler.xml file correctly.
> 
> 
> Diffs
> -----
> 
>   data/conf/fair-scheduler-test.xml PRE-CREATION 
>   
> itests/hive-unit-hadoop2/src/test/java/org/apache/hive/jdbc/TestSchedulerQueue.java
>  79878ba 
>   shims/0.23/src/main/java/org/apache/hadoop/hive/shims/Hadoop23Shims.java 
> 6125714 
> 
> Diff: https://reviews.apache.org/r/27292/diff/
> 
> 
> Testing
> -------
> 
> Added test cases to for various queue allocation rules.
> 
> 
> Thanks,
> 
> Prasad Mujumdar
> 
>

Reply via email to