[
https://issues.apache.org/jira/browse/HIVE-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14223431#comment-14223431
]
Szehon Ho commented on HIVE-4766:
---------------------------------
Hi Chaoyu, this is a very welcome fix. I'll put some small style/wording
suggestions here as there's no rb.
# First, can you put some whitespace in ThriftBinaryCLIService after the cast
of (int), and also before the second argument of getTimeVar(), which is
TimeUnit.seconds?
# For hive.server2.thrift.login.timeout, current description "timeout for the
thrift client to login (in seconds)" shouldn't mention seconds as now HiveConf
timevar supports different units (ie, 20000ms would work as well), and
conversion to outUnit. But please verify that the final argument passed to
ThriftBinaryCliService is still 20 seconds.
# Also for hive.server2.thrift.login.timeout, wording can be changed to
mention HiveServer2 like "Timeout for thrift clients during login to
HiveServer2".
# For hive.server2.thrift.exponential.backoff.slotlength, it can be "Binary
exponential backoff time for thrift clients during login to HiveServer2, for
retries until hitting thrift client timeout". Also if possible to change, I
think the convention is to have a period between each word (slotlength).
+ [~leftylev] for any other opinions about the new conf wordings. Thanks.
> Support HS2 client login timeout when the thrift thread max# is reached
> -----------------------------------------------------------------------
>
> Key: HIVE-4766
> URL: https://issues.apache.org/jira/browse/HIVE-4766
> Project: Hive
> Issue Type: Improvement
> Components: HiveServer2
> Affects Versions: 0.10.0
> Reporter: Chaoyu Tang
> Assignee: Chaoyu Tang
> Labels: TODOC15
> Fix For: 0.15.0, 0.14.1
>
> Attachments: HIVE-4766.patch
>
>
> HiveServer2 client (beeline) hangs in login if the thrift max thread# has
> been reached. It is because the server crashes due to a defect in currently
> used thrift 0.9.0. When hive is upgraded to use a new version of Thrift (say
> thrift 1.0), HS2 should support client login timeout instead of current
> hanging.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
