[ 
https://issues.apache.org/jira/browse/HIVE-4766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14224226#comment-14224226
 ] 

Lefty Leverenz commented on HIVE-4766:
--------------------------------------

Looks good to me, [~ctang.ma], except that Thrift should be capitalized in the 
descriptions on lines 1667, 1668, and 1670.  I don't understand the slot 
concept but that probably doesn't need explanation ... sure enough, it's 
covered in Wikipedia.

Apologies for not using the review board -- my login password is stored on a 
broken laptop.

> Support HS2 client login timeout when the thrift thread max# is reached
> -----------------------------------------------------------------------
>
>                 Key: HIVE-4766
>                 URL: https://issues.apache.org/jira/browse/HIVE-4766
>             Project: Hive
>          Issue Type: Improvement
>          Components: HiveServer2
>    Affects Versions: 0.10.0
>            Reporter: Chaoyu Tang
>            Assignee: Chaoyu Tang
>              Labels: TODOC15
>             Fix For: 0.15.0, 0.14.1
>
>         Attachments: HIVE-4766.1.patch, HIVE-4766.patch
>
>
> HiveServer2 client (beeline) hangs in login if the thrift max thread# has 
> been reached. It is because the server crashes due to a defect in currently 
> used thrift 0.9.0. When hive is upgraded to use a new version of Thrift (say 
> thrift 1.0), HS2 should support client login timeout instead of current 
> hanging.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to