> On Nov. 25, 2014, 1:08 a.m., Xuefu Zhang wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java, > > line 92 > > <https://reviews.apache.org/r/28422/diff/1/?file=775072#file775072line92> > > > > Could we add an interface at SparkClient and call that directly here? > > This is to be consistent with other methods of similar functionality.
Sure. Will fix. - Jimmy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28422/#review62913 ----------------------------------------------------------- On Nov. 25, 2014, 12:08 a.m., Jimmy Xiang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28422/ > ----------------------------------------------------------- > > (Updated Nov. 25, 2014, 12:08 a.m.) > > > Review request for hive and Xuefu Zhang. > > > Bugs: HIVE-8855 > https://issues.apache.org/jira/browse/HIVE-8855 > > > Repository: hive-git > > > Description > ------- > > Remote Hive Spark client is enabled to calculate reducer number. > > > Diffs > ----- > > .gitignore c5decaf > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveSparkClient.java > fc63180 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/HiveSparkClientFactory.java > 3a89ca6 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/LocalHiveSparkClient.java > 4bd3b43 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/RemoteHiveSparkClient.java > 93d486f > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java 3613784 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkUtilities.java > e2d129c > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSession.java > fe6bce1 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/session/SparkSessionImpl.java > 650ac11 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SetSparkReducerParallelism.java > f2bb15f > > Diff: https://reviews.apache.org/r/28422/diff/ > > > Testing > ------- > > > Thanks, > > Jimmy Xiang > >
