Downloaded, checked signatures, checked no binaries in source tarball 
(especially maven-wrapper.jar). Checked that contents of tar.gz are equal to 
contents of git at the release tag. Built using build instructions for Maven 
wrapper, ‘./mvnw clean install -DskipTests’ on Ubuntu JDK 8. Checked LICENSE, 
NOTICE, DISCLAIMER. Ran RAT.

The copyright notice in NOTICE should include all years, not just the current 
year. Not a huge deal, but please fix in future releases.

+1

(Nothing to do with the release vote, but I also checked the website using 
https://whimsy.apache.org/pods/ <https://whimsy.apache.org/pods/>. Only one 
warning. Well done.)

Julian



> On Sep 23, 2021, at 12:43 AM, Francois Papon <[email protected]> 
> wrote:
> 
> Ok for the 1.0.0 rather than 1.0.0.RC1, I missed the discussion about that.
> 
> +1 for the vote and good job guys for the first major release!
> 
> regards,
> 
> François
> [email protected]
> [email protected]
> 
> Le 23/09/2021 à 09:31, Hans Van Akelyen a écrit :
>> Hi François,
>> 
>> You are right, I should not have had it marked as released. I have
>> "unreleased" the version and changed the number to 1.0.0.
>> It was during the final weeks that we decided to go for Major.Minor.Patch
>> and our work in progress was 1.0-SNAPSHOT.
>> 
>> In the mail for general incubator and our communication to the end users we
>> will use the link you provided, it did not come to my mind that the first
>> one would not work when not logged in to Jira.
>> 
>> On the last part I am not sure, Julian also said we had to remove the -rc1
>> from the archives we were making as when releasing from staging to release
>> in dist you are doing an svn move so the top folder should contain the
>> candidate name but not the actual artifacts.
>> 
>> If a vote succeeds we are not supposed to change the version in the pom as
>> it would affect the checksums and require re-creating and re-signing the
>> artifacts.
>> 
>> we are still releasing "1.0.0" when the vote on the candidate passes.
>> 
>> Cheers,
>> Hans
>> 
>> 
>> On Thu, 23 Sept 2021 at 09:12, Francois Papon <[email protected]>
>> wrote:
>> 
>>> Hi,
>>> 
>>> It's better to share the public release note because people can see
>>> without login into Jira:
>>> 
>>> 
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12324323&version=12350233
>>> 
>>> Another side note, it's better to change the version to "released" after
>>> the end of the vote.
>>> 
>>> The version is 1.0.0-RC1 but the version in Jira is 1.0.
>>> 
>>> In the pom.xml of the source I can see that the version is 1.0.0 and I
>>> think it should be 1.0.0.RC1.
>>> 
>>> The users can be confused about the version.
>>> 
>>> regards,
>>> 
>>> François
>>> [email protected]
>>> [email protected]
>>> 
>>> Le 21/09/2021 à 14:10, Hans Van Akelyen a écrit :
>>>> Hi All,
>>>> 
>>>> After a thorough testing period for Hop 0.99, we are ready to release
>>>> version 1.0.0 to the public. All issues raised during the previous
>>> release
>>>> have been resolved. Dubious code has either been rewritten or removed
>>> from
>>>> this release.
>>>> 
>>>> This release contains no new features, only further cleanup and code
>>>> hardening has been done. I would like to thank everyone that participated
>>>> in filing, testing and resolving issues.
>>>> 
>>>> Build instructions can be found in the README included.
>>>> 
>>>> The tag to be voted on is 1.0.0rc1 (commit 8a1fc96 ):
>>>> https://github.com/apache/incubator-hop/tree/1.0.0-rc1
>>>> 
>>>> The release files, including signatures, digests, etc. can be found at:
>>>> 
>>> https://dist.apache.org/repos/dist/dev/incubator/hop/apache-hop-1.0.0-incubating-rc1/
>>>> The SHA512 Checksum for these artifacts is:
>>>> Source:
>>> b7e2fdf14fcacaf937bf3e4ffedba6870a0b97965c97e0be0013acde308e161035fce5dfcb5254f96194cfe7a944bcfd5b3d8541b51435f732d0a5f61e498550
>>>> Client:
>>> f9dd913c09a547a21e0c0c26ec71040dd34b753e83d4638982a1e5b525f4219e2e33c54989305461c793ecdd779ffab953f65872f5d809267938fd62ddf123c2
>>>> Release artifacts are signed with the following key:
>>>> https://keyserver.ubuntu.com/pks/lookup?op=get&search=0x9a8a628dd4f4aa1e
>>>> 
>>>> For more information about the contents of this release, see:
>>>> https://issues.apache.org/jira/projects/HOP/versions/12350233
>>>> 
>>>> Please vote on releasing this package as Apache Hop (incubating) 1.0.0!
>>>> 
>>>> The vote is open for 72 hours and passes if
>>>> a majority of at least 3 +1 PMC votes are cast.
>>>> 
>>>> [ ] +1 Release this package as Apache Hop (incubating) 1.0.0
>>>> [ ] +0 No opinion
>>>> [ ] -1 Do not release this package because ...
>>>> 
>>>> Best Regards,
>>>> Hans
>>>> 

Reply via email to