Justin Erenkrantz wrote:
>Both Cliff and OtherBill sent me emails complaining about the
>change to strcasecmp in some places to support Brian Pane's
>new hash code in util_filter.c. (Never mind that a lot of
>the code already did strcasecmp...)
>
>This patch makes the filter name lowercase for the searches
>and lets us use strcmp. (I only searched for files that
>used frec->name directly...)
>
>Please review and test. My commits are getting an awful lot
>of negative feedback lately, so I'm going to switch to R-T-C.
>So, I'll need 3 +1s to commit this. -- justin
>
Alternatively, how about just leaving everything capitalized
and removing the case-insensitivity support in add_any_filter?
I wasn't happy about having to normalize the case in add_any_filter
in order to make the hash tables match the semantics of the
strcasecmp loop that they replaced, so I'd rather drop the
lowercasing in add_any_filter and just use the capital forms
throughout (with case-insensitive comparisons) unless that
breaks something else.
--Brian
