On Tuesday 04 September 2001 12:08, Justin Erenkrantz wrote:

Wouldn't this be a much cleaner patch if we went to upper case
instead of lower-case?  I realize that is a detail, but currently, most
of the filters are registered as upper case, so we would have fewer
places to modify.

Ryan

> Both Cliff and OtherBill sent me emails complaining about the
> change to strcasecmp in some places to support Brian Pane's
> new hash code in util_filter.c.  (Never mind that a lot of
> the code already did strcasecmp...)
>
> This patch makes the filter name lowercase for the searches
> and lets us use strcmp.  (I only searched for files that
> used frec->name directly...)
>
> Please review and test.  My commits are getting an awful lot
> of negative feedback lately, so I'm going to switch to R-T-C.
> So, I'll need 3 +1s to commit this.  -- justin

______________________________________________________________
Ryan Bloom                              [EMAIL PROTECTED]
Covalent Technologies                   [EMAIL PROTECTED]
--------------------------------------------------------------

Reply via email to