On Sunday 23 September 2001 06:58 pm, Justin Erenkrantz wrote:
> Take two.
>
> As Greg suggested, this merges the dechunk and core filters back
> to one filter. (This makes the diff in http_protocol.c a bit
> gnarly.)
>
> Other significant changes is that the HTTP_IN (ap_http_filter) is
> now a request-level filter rather than a connection-level filter.
> This makes a lot more sense to me.
>
> This passes all of the tests in httpd-test (not to say that this
> is perfect or anything). There is a patch at the bottom for
> mod_input_body_filter.c in httpd-test that is required. (It was
> expecting > readbytes to be read when asking for readbytes).
>
> Comments and feedback? -- justin
I don't see how this works at all for pipelined requests. You moved the HTTP_IN
filter from a connection filter to a request filter. But, the only connection filter we
have is the CORE_iN filter. All that filter does, is to pass the socket up to the
HTTP_IN filter. The problem is that HTTP_IN will be destroyed in between requests,
so the second request will be lost. I am continuing to read the code, so I may see
what I am missing, but in the mean time, Justin, if you could explain that to me,
it would make my review go a lot faster.
Ryan
______________________________________________________________
Ryan Bloom [EMAIL PROTECTED]
Covalent Technologies [EMAIL PROTECTED]
--------------------------------------------------------------
