On Sun, 23 Sep 2001, Justin Erenkrantz wrote:
> Index: buckets/apr_buckets_pipe.c
> ===================================================================
> RCS file: /home/cvs/apr-util/buckets/apr_buckets_pipe.c,v
> retrieving revision 1.41
> diff -u -r1.41 apr_buckets_pipe.c
> --- buckets/apr_buckets_pipe.c 2001/09/22 22:36:07 1.41
> +++ buckets/apr_buckets_pipe.c 2001/09/24 01:48:04
> @@ -110,10 +110,6 @@
> *str = a->data;
> if (rv == APR_EOF) {
> apr_file_close(p);
> - if (block == APR_NONBLOCK_READ) {
> - /* XXX: this is bogus, should return APR_SUCCESS */
> - return APR_EOF;
> - }
> }
> }
> return APR_SUCCESS;
PS: ++1 to getting rid of these damned things. Good riddance! =-)
We should grep through the code after this is committed to look for places
that actually accounted for apr_bucket_read() returning APR_EOF, since
they shouldn't have to do that. I know there are at least a few of them
hanging around out there (maybe the chunk output filter?).
--Cliff
--------------------------------------------------------------
Cliff Woolley
[EMAIL PROTECTED]
Charlottesville, VA
