On Saturday 10 November 2001 01:03 pm, Ryan Bloom wrote: > On Saturday 10 November 2001 12:51 pm, Brian Pane wrote: > > Ryan Bloom wrote: > > [...] > > > > >>Later today I'll post a new patch that turns error_str and time_str > > >>into char*. > > > > > >Just remove them from the structure all together. They aren't necessary > > >in that structure. > > > > Where else would you put them? If they move out of the filter > > context struct, they'll have to move someplace where they're > > still accessible by the filter in subrequests (to handle the > > case of shtml files included within other shtml files). > > All we do with them is copy them into the filter context structure. Then> we use >that copy when we parse the string. But, parsing is a > non-destructive operation. So, we can get rid of them from the structure, > and just use the copies in the directory structure. > > Ryan
Damn, I counted the arguments to ap_parse_ssi_string incorrectly. I still think we can get rid of those strings, but I need to look at the code a bit closer. Ryan ______________________________________________________________ Ryan Bloom [EMAIL PROTECTED] Covalent Technologies [EMAIL PROTECTED] --------------------------------------------------------------
