Ryan Bloom wrote: >On Saturday 10 November 2001 12:51 pm, Brian Pane wrote: > >>Ryan Bloom wrote: >>[...] >> >>>>Later today I'll post a new patch that turns error_str and time_str >>>>into char*. >>>> >>>Just remove them from the structure all together. They aren't necessary >>>in that structure. >>> >>Where else would you put them? If they move out of the filter >>context struct, they'll have to move someplace where they're >>still accessible by the filter in subrequests (to handle the >>case of shtml files included within other shtml files). >> > >All we do with them is copy them into the filter context structure. Then >we use that copy when we parse the string. But, parsing is a non-destructive >operation. So, we can get rid of them from the structure, and just use the >copies in the directory structure. >
Huh? If you're referring to the ap_ssi_parse_string() calls in handle_config(), note that ctx->error_str isn't an input to the parsing operation, it's an output. When someone uses <!--#config errmsg="my error message" --> the new error message gets stored in ctx->error_str, where it's usable in the subrequests for included shtml files. My updated patch (the one I sent today) preserves these semantics but skips the malloc of error_str and time_str until/unless they're needed. --Brian
