[forwarding to apr] Back in revision 1.2 of apr/include/apr_thread_mutex.h we added #if APR_HAS_THREADS blocks around all declarations in the header. This is what's cauing Martin's build failure. I'm not seeing this same pattern in the original apr_lock.h files.
What is the right way to handle this? I don't think we should we be conditionally compiling declarations, only implementations. We can either go for runtime errors (APR_ENOTIMPL) when functionality is non-existant (--disable-threads), or we'll have to go around putting #if blocks around all the code references. -aaron On Mon, Nov 19, 2001 at 05:54:40PM +0100, Martin Kraemer wrote: > Since three days, Apache-2.0 fails to compile unter FreeBSD: > ssl_util.c:399: `APR_THREAD_MUTEX_DEFAULT' undeclared (first use in this function) > > It appears that APR_THREAD_MUTEX_DEFAULT is used in several places > without a check for APR_HAS_THREADS. That should not be the case, > especially because there is an abstraction layer below.........
