On Monday 19 November 2001 09:19 am, Aaron Bannert wrote: > [forwarding to apr] > > Back in revision 1.2 of apr/include/apr_thread_mutex.h we added #if > APR_HAS_THREADS blocks around all declarations in the header. This is > what's cauing Martin's build failure. I'm not seeing this same pattern > in the original apr_lock.h files. > > What is the right way to handle this? I don't think we should we be > conditionally compiling declarations, only implementations. We can > either go for runtime errors (APR_ENOTIMPL) when functionality is > non-existant (--disable-threads), or we'll have to go around putting #if > blocks around all the code references.
We should always opt for compile time errors over run-time errors, because it makes the error easier to see and fix. I would say, fix mod_ssl by #if'ing the code. Ryan ______________________________________________________________ Ryan Bloom [EMAIL PROTECTED] Covalent Technologies [EMAIL PROTECTED] --------------------------------------------------------------
