[EMAIL PROTECTED] wrote:
> jwoolley 2002/05/31 00:43:22
>
> Modified: modules/test mod_bucketeer.c
> Log:
> we should be copying over all metadata buckets we don't understand, not
> just error buckets.
>
> Revision Changes Path
> 1.12 +5 -4 httpd-2.0/modules/test/mod_bucketeer.c
>
> Index: mod_bucketeer.c
> ===================================================================
> RCS file: /home/cvs/httpd-2.0/modules/test/mod_bucketeer.c,v
> retrieving revision 1.11
> retrieving revision 1.12
> diff -u -d -u -r1.11 -r1.12
> --- mod_bucketeer.c 30 May 2002 21:10:19 -0000 1.11
> +++ mod_bucketeer.c 31 May 2002 07:43:22 -0000 1.12
> @@ -141,10 +141,11 @@
> continue;
> }
>
> - if (AP_BUCKET_IS_ERROR(e)) {
> - apr_bucket *err_copy;
> - apr_bucket_copy(e, &err_copy);
> - APR_BRIGADE_INSERT_TAIL(ctx->bb, err_copy);
> + if (e->length == 0) {
Looks like magic to me - perhaps wrap it in AP_BUCKET_IS_METADATA()?
Cheers,
Ben.
--
http://www.apache-ssl.org/ben.html http://www.thebunker.net/
"There is no limit to what a man can do or how far he can go if he
doesn't mind who gets the credit." - Robert Woodruff
