[EMAIL PROTECTED] wrote: >>To solve the problem that Blaise noted, I believe we'll have to >>make the content_length filter stop reading buckets altogether >>(which I think is absolutely the right thing to do, but we'll >>have to find some other place to compute r->bytes_sent). >> >> > >Compute r->bytes_sent in core_output_filter. That is the only way to get >an accurate number anyway. >
I agree. We'll have to record the size of the response header in the HTTP filter in order to subtract it later (because mod_log_config reports bytes sent excluding the header), but that part is easy. And that will let us avoid doing reads in the C-L filter altogether, which makes it easier to later add zero-copy output of pipe buckets on systems where sendfile can handle pipes as input. I'll post an updated C-L filter patch later today. Brian
