Can somebody _please_ take some time to review and tell me if the patch is okay.
Just a observation : I do understand that everybody is busy doing their own set of things, but then - do you really solicit patches from non-committers ?. I've been a silent observer since the last couple of months, and as-per my observation, everytime a non-committer sends a patch, it takes a couple of cycles before somebody even responds back to the patch (let alone commit it). When somebody posts a patch, I'm sure he/she definitely looks forward for some sort of input from you guys (the core developers/committers, best of the breed etc) - atleast something like "its all crap" / "you may want to do this also" / "this is all good" / something else. Am I wrong here ?.. Does anybody not want a response when they post a patch ?. Talking specifically of my patches, the majority of the commits to the mod_ssl source was done by Cliff / Justin / DougM. I do realize that they're busy with other things also - but then, I've not seen many others doing any development on the SSL front. So, whom do I approach to solicit any feedback ?. -Madhu > -----Original Message----- > From: MATHIHALLI,MADHUSUDAN (HP-Cupertino,ex1) > [mailto:madhusudan_mathihalli@;hp.com] > Sent: Wednesday, October 23, 2002 4:52 PM > To: '[EMAIL PROTECTED]' > Subject: [PATCH] Try to use OPENSSL_free instead of free > > > Based on Nadav Har'El's e-mail on the mod_ssl community > (http://marc.theaimsgroup.com/?l=apache-modssl&m=103540998016916&w=2), > here's a patch for 2.0's mod_ssl. > > > -Madhu > > Index: ssl_engine_kernel.c > =================================================================== > RCS file: /home/cvspublic/httpd-2.0/modules/ssl/ssl_engine_kernel.c,v > retrieving revision 1.78 > diff -u -r1.78 ssl_engine_kernel.c > --- ssl_engine_kernel.c 14 Oct 2002 04:15:58 -0000 1.78 > +++ ssl_engine_kernel.c 23 Oct 2002 23:46:38 -0000 > @@ -968,7 +968,7 @@ > X509_NAME *name = > X509_get_subject_name(sslconn->client_cert); > char *cp = X509_NAME_oneline(name, NULL, 0); > sslconn->client_dn = apr_pstrdup(r->connection->pool, cp); > - free(cp); > + modssl_free(cp); > } > > clientdn = (char *)sslconn->client_dn; > @@ -1299,11 +1299,11 @@ > iname ? iname : "-unknown-"); > > if (sname) { > - free(sname); > + modssl_free(sname); > } > > if (iname) { > - free(iname); > + modssl_free(iname); > } > } > > @@ -1555,7 +1555,7 @@ > "Certificate with serial > %ld (0x%lX) " > "revoked per CRL from issuer %s", > serial, serial, cp); > - free(cp); > + modssl_free(cp); > } > > X509_STORE_CTX_set_error(ctx, > X509_V_ERR_CERT_REVOKED); > @@ -1593,6 +1593,7 @@ > ap_log_error(APLOG_MARK, APLOG_DEBUG, 0, s, > SSLPROXY_CERT_CB_LOG_FMT "%s, sending %s", > sc->vhost_id, msg, dn ? dn : "-uknown-"); > + modssl_free(dn); > } > > /* > > Index: ssl_engine_vars.c > =================================================================== > RCS file: /home/cvspublic/httpd-2.0/modules/ssl/ssl_engine_vars.c,v > retrieving revision 1.20 > diff -u -r1.20 ssl_engine_vars.c > --- ssl_engine_vars.c 28 May 2002 21:47:31 -0000 1.20 > +++ ssl_engine_vars.c 23 Oct 2002 23:51:25 -0000 > @@ -334,7 +334,7 @@ > xsname = X509_get_subject_name(xs); > cp = X509_NAME_oneline(xsname, NULL, 0); > result = apr_pstrdup(p, cp); > - free(cp); > + modssl_free(cp); > resdup = FALSE; > } > else if (strlen(var) > 5 && strcEQn(var, "S_DN_", 5)) { > @@ -346,7 +346,7 @@ > xsname = X509_get_issuer_name(xs); > cp = X509_NAME_oneline(xsname, NULL, 0); > result = apr_pstrdup(p, cp); > - free(cp); > + modssl_free(cp); > resdup = FALSE; > } > else if (strlen(var) > 5 && strcEQn(var, "I_DN_", 5)) { > > Index: ssl_toolkit_compat.h > =================================================================== > RCS file: /home/cvspublic/httpd-2.0/modules/ssl/ssl_toolkit_compat.h,v > retrieving revision 1.25 > diff -u -r1.25 ssl_toolkit_compat.h > --- ssl_toolkit_compat.h 21 Aug 2002 19:12:46 -0000 1.25 > +++ ssl_toolkit_compat.h 23 Oct 2002 23:46:38 -0000 > @@ -105,6 +105,8 @@ > > #define modssl_set_cipher_list SSL_set_cipher_list > > +#define modssl_free OPENSSL_free > + > #define EVP_PKEY_reference_inc(pkey) \ > CRYPTO_add(&((pkey)->references), +1, CRYPTO_LOCK_X509_PKEY) > > @@ -147,6 +149,8 @@ > > #define modssl_set_cipher_list(ssl, l) \ > SSL_set_cipher_list(ssl, (char *)l) > + > +#define modssl_free free > > #ifndef PEM_F_DEF_CALLBACK > #define PEM_F_DEF_CALLBACK PEM_F_DEF_CB >
