* David Reid ([EMAIL PROTECTED]) wrote : > Maybe we should have another directive for the suexec log? But I agree it > shouldn't be hardcoded. > No, we have a --with-suexec-logfile config option, but if that isn't used, currently the location remains hardcoded. We *should* encourage people to use --with-suexec-logfile; but we shouldn't have suexec break into many pieces just 'cos they don't... -Thom
> > ----- Original Message ----- > From: "Thom May" <[EMAIL PROTECTED]> > To: <[EMAIL PROTECTED]> > Sent: Tuesday, December 31, 2002 11:39 AM > Subject: [PATCH] remove hardcoding of suexec log location > > > > This is to fix PR 15713 > > "suexec-logfile has hardcoded default instead of being > > placed in --logfiledir" > > > > I'm not sure it's right, though, since I'm not sure of the status of > suexec > > on win32/other places where ap_config_layout.h isn't available. > > -Thom > > > > > > Index: support/suexec.h > > =================================================================== > > RCS file: /home/cvspublic/httpd-2.0/support/suexec.h,v > > retrieving revision 1.7 > > diff -u -u -r1.7 suexec.h > > --- support/suexec.h 27 Sep 2002 23:53:04 -0000 1.7 > > +++ support/suexec.h 30 Dec 2002 12:10:17 -0000 > > @@ -62,6 +62,12 @@ > > #define _SUEXEC_H > > > > /* > > + * Include ap_config_layout so we can work out where the default > htdocsdir > > + * and logsdir are. > > + */ > > +#include "ap_config_layout.h" > > + > > +/* > > * HTTPD_USER -- Define as the username under which Apache normally > > * runs. This is the only user allowed to execute > > * this program. > > @@ -117,7 +123,7 @@ > > * debugging purposes. > > */ > > #ifndef AP_LOG_EXEC > > -#define AP_LOG_EXEC "/usr/local/apache2/logs/cgi.log" /* Need me? */ > > +#define AP_LOG_EXEC DEFAULT_EXP_LOGFILEDIR "/suexec_log" /* Need me? */ > > #endif > > > > /* > > @@ -126,7 +132,7 @@ > > * that can be used for suEXEC behavior. > > */ > > #ifndef AP_DOC_ROOT > > -#define AP_DOC_ROOT "/usr/local/apache2/htdocs" > > +#define AP_DOC_ROOT DEFAULT_EXP_HTDOCSDIR > > #endif > > > > /* > >
