My fast-draw opinion is that it should be set to NULL (because it doesn't exist) and the routines that segfault not be called when r->filename is NULL. This pulls the if statements from the called routine, replacing them with (hopefully) only one if statement in the caller. Let this philosopy percolate up, and we wind up with clean code, no?
IOW, every module has to deal with r->filename being NULL, and they can be a little clever about it to avoid having to check r->filename all the time. That's fine, that's the way it is today.
Cliff, what do you mean by the "r->filename problem". Just that all necessary checks aren't in place, or that there may be another cleaner grand scheme?
