On Wed, Jun 09, 2004 at 05:23:38PM -0400, Allan Edwards wrote: > Running ProxyPass with mod_deflate results in > an extraneous 20 bytes being tacked onto 304 > responses from the backend. > > The problem is that mod_deflate doesn't handle > the zero byte body, adds the gzip header and > tries to compress 0 bytes. > > This patch detects the fact that there was no > data to compress and removes the gzip header > from the bucket brigade.
Wouldn't it be simpler to just check for a brigade containing just EOS and do nothing for that case in the first place? But the fact that the proxy passes such a brigade through the output filters in the first place sounds like the real bug, it doesn't happen for a non-proxied 304 response. joe
