Philippe M. Chiasson wrote: > The only moment where it's appropriate for a module to push Defines > values into > ap_server_config_defines is during the register_hook phase. The problem > is that > this phase is called earlier for compiled-in modules than for loaded > modules. > So a module trying to add to it thru > apr_array_push(ap_server_config_defines) at > that time will succeed, only if it's dynamically loaded, and most likely > segfault > otherwise. > > The following patches delays ap_setup_prelinked_modules to slightly > later, after > ap_server_config_defines has been proprely initialized.
that all seems reasonable. does anyone know of any historical (or other) reasons why this shouldn't be shuffled a bit? --Geoff
