On Wed, Dec 07, 2005 at 10:21:10AM +0100, Plm, Rdiger, VIS wrote: > I would like to set the c->aborted in mod_proxy's proxy_handler after the > run_scheme_handler. > > Reason: > > 1. We can define a clear interface for the scheme handlers here: > If the backend broke before you sent headers just return BAD_GATEWAY > and send nothing, if it broke afterwards just return BROKEN_BACKEND > (or whatever you like that should be defined for this case). > The proxy handler would handle this BROKEN_BACKEND return code and > do the 'right' thing (currently setting c->aborted). > Thus we do not have the need to put the burden of the details on > the schema handler (why I regard it as a burden see 2.)
Feel free to commit a patch. =) > 2. I am not 100% percent happy with the c->aborted approach as the original > intention of c->aborted was another one (The connection to the *client* > broke > not to the *backend*). I admit that I do not see any other approach > currently, so we should stick with this, but if we decide to change this > later on and we follow 1. then it is much easier to change as we have this > code only in *one* location and not in every scheme handler. But, that's exactly what we want: we must abort the connection to the client because we can't complete the response. -- justin
