Re: svn commit: r425677 - /httpd/httpd/branches/2.2.x/STATUS

[Sander Temme]

Nick,

On Jul 26, 2006, at 1:40 AM, [EMAIL PROTECTED] wrote:

Modified: httpd/httpd/branches/2.2.x/STATUS

URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.2.x/STATUS? rev=425677&r1=425676&r2=425677&view=diff ====================================================================== ========

--- httpd/httpd/branches/2.2.x/STATUS (original)
+++ httpd/httpd/branches/2.2.x/STATUS Wed Jul 26 01:40:24 2006
@@ -103,6 +103,10 @@
       Fix brokenness on certain platforms when building with -DDEBUG.
       http://svn.apache.org/viewvc?view=rev&revision=381783
       +1 sctemme, fielding
+      -1 niq: Why are we hacking a third-party package as bundled,
+              rather than upstream?  This has potential for chaos
+              for modules (and we have a history of PCRE trouble)
+              as well as a maintenance nightmare!

Have you reviewed the patch? This is a small modification that takes unsupported code out of the compile path when building with -DDEBUG. I have this in all my working copies. It does not break the PCRE interface. In the following message to [EMAIL PROTECTED], PCRE author Philip Hazel all but admits forgetting to ifdef these calls out in this file (which gets #included from pcre.c only if DEBUG is #defined): http://mail-archives.apache.org/mod_mbox/httpd-dev/200504.mbox/% [EMAIL PROTECTED]

This just makes it easier for folks to build debug builds and help us out: http://mail-archives.apache.org/mod_mbox/httpd-dev/200604.mbox/% [EMAIL PROTECTED]

Please reconsider your bale.

S.

--
[EMAIL PROTECTED]              http://www.temme.net/sander/
PGP FP: 51B4 8727 466A 0BC3 69F4  B7B8 B2BE BC40 1529 24AF

The real solution of course, is to upgrade to the current release of PCRE, version 6.7. However, we should probably not do that on the stable branches.

smime.p7s
Description: S/MIME cryptographic signature