> -----Ursprüngliche Nachricht----- > Von: Davi Arnaut > Gesendet: Donnerstag, 26. Oktober 2006 13:47 > An: [email protected] > Betreff: Re: svn commit: r467655 - in /httpd/httpd/trunk: > CHANGES docs/manual/mod/mod_cache.xml > modules/cache/mod_cache.c modules/cache/mod_cache.h > > > Graham Leggett wrote: > > On Wed, October 25, 2006 11:48 pm, Davi Arnaut wrote: > >
> >> What Joe's patch does is remove this first implicitly > created bucket > >> from the brigade, placing it on the brigade on a temporary > brigade for > >> sending it to the client. > > > > Ok, this makes more sense, but in its current form the > temporary brigade > > should not be necessary. > > But it would be better. We don't need to keep creating brigades with > apr_brigade_split(), we could only move the buckets to a temporary +1 on this. Creating brigades over and over again consumes memory that is only freed once the request pool gets cleared. So if we create a lot of brigades we have a temporary memory leak here. AFAIK the (data only?) memory allocated by buckets is freed immediately when they get destroyed. Regards Rüdiger
