I've been trying to review the mod_deflate updates.

The deflate filter stuff looks good.  But I'm confused by the
validation buffer usage in the input filter.  You only allocate
a validation buffer at line 1177 (STREAM_END), yet you test
it at line 1134: presumably that'll only ever test positive
on a subsequent call.  Shouldn't the block around 1134 be
brought to the top of the function, so it catches the case
of a last brigade containing only an EOS?

-- 
Nick Kew

Application Development with Apache - the Apache Modules Book
http://www.apachetutor.org/

Reply via email to