On 17 Jan 2007, at 16:06, Niklas Edmundsson wrote:
On Wed, 17 Jan 2007, Giuliano Gavazzi wrote:
rv = apr_file_seek(dobj->hfd, APR_SET, &off);
does not rewind if the file has been opened with
APR_FOPEN_BUFFERED. Now, I
This is an APR bug, I submitted a bug report for it a while ago. I
worked around it by not using buffering at all and writing larger
chunks when writing headers.
I am not too concerned about bleeding edge performance, so I think I
will content myself by not using APR_FOPEN_BUFFERED. After all I am
talking of a gain factor of 100 in performance when compared to SSI
pages without caching, and it is enough.
There is another potential problem in store_headers, if the
headers file is
Is this in trunk or in 2.2.4 proper? You should probably ignore
mod_disk_cache on trunk until that situation is settled.
I could work on mod_disk_cache from 2.2.4 proper, and find what
causes the bug with SSI pages, but I do not see why I should spend
another couple of days on it now that I have fixed the r470455 (that
is trunk) release. After all the situation might settle quicklier (I
think Shakespeare used this...) if I submit my patches! And I suppose
now you agree that the extra indentation on my patch stemmed from the
broken nature of the original code!
If you're into trying patches you could give my mod_disk_cache
jumbopatch a spin, note however that it's only been tested for
mostly static content (directory indexes being an exception). You
can find the patch at http://issues.apache.org/bugzilla/
show_bug.cgi?id=39380 ...
I think I will give it a spin, more to give you feedback on possible
issues with SSI.
g
