On Thu, 2007-03-15 at 17:30 +0100, Rainer Jung wrote:
> Mladen Turk wrote:
> > Jean-Frederic wrote:
> >>
> >> - if (status != APR_SUCCESS) {
> >> + if (! isok) {
> >> /* We had a failure: Close connection to backend */
> >> conn->close++;
> >
> > This is what concerns me (not your code but the old conn->close++.
> > Hope It wasn't me ;)
>
> Caution: this line exactly has been added as a patch for BZ 40310. I
> didn't follow this too closely, but it looked like a serious issue for
> the user.
>
> http://issues.apache.org/bugzilla/show_bug.cgi?id=40310
isok is set to zero when status != APR_SUCESS in 3 new locations so the
conn->close++ should be called as before the patch.
Cheers
Jean-Frederic
>
> The user comments, that the fix might be relevant for mod_jk too, which
> is why I have it on my open items list. But i didn't investigate until now.
>
> >
> > Anyhow, AJP should keep the connection to backend open except
> > when the notification the client has closed the connection is
> > desired and configured.
> > I suppose this is one of the reasons why people are saying that
> > ajp is not much faster then http in mod_proxy.
> >
> > In any case, +1 for the patch.
> >
> > Regards,
> > Mladen.
