On Apr 4, 2007, at 10:27 AM, Plüm, Rüdiger, VF-Group wrote:


Hmmm... I like this idea. Not sure about the use of '/'
as the delim (simply because of its "other" meanings) but
that's secondary.

Of course, we can't use strtok, since sticky is a const
char and we can't be shoving NULLs in there :)

Plus does it make sense to split the sticky string everytime we search
for a route? From my performance feeling this split should be done during
configuration time.

Agreed... It doesn't change.

How about adding either a const char * some_name[FIXED_VALUE] or an
apr_array_header_t * to the end of struct proxy_balancer to store the results of the split and setting sticky = some_name[last_non_null_entry] for backward
compatibility?


We already have an existing context we could overload
or simply append another element to the struct.

Of course, doing that really confuses the whole issue, since
we're doing all these weird things to get around changing
sticky from a const char* to a apr_array_header_t*...

Sooo... how about in trunk making it right (sticky -> apr_array_header_t*)
and in 2.2 appending sticky_table (apr_array_header_t*)...

Reply via email to