> -----Ursprüngliche Nachricht----- > Von: jean-frederic clere [mailto:[EMAIL PROTECTED] > Gesendet: Montag, 10. September 2007 13:23 > An: [email protected] > Cc: Jim Jagielski > Betreff: Re: svn commit: r573264 - > /httpd/httpd/trunk/include/scoreboard.h > > > Plüm wrote: > > > >> -----Ursprüngliche Nachricht----- > >> Von: jean-frederic clere > >> Gesendet: Montag, 10. September 2007 12:01 > >> An: [email protected] > >> Betreff: Re: svn commit: r573264 - > >> /httpd/httpd/trunk/include/scoreboard.h > >> > >> > >> Jim Jagielski wrote: > >>> Ruediger Pluem wrote: > >>>> Because it was > >>>> > >>>> int ap_proxy_lb_workers(void); > >>>> > >>>> and not > >>>> > >>>> PROXY_DECLARE(int)ap_proxy_lb_workers(void); > >>>> > >>> Yep. Ideally, of course, a design like mod_ssl with the > >>> ssl_private.h usage is nice, because there you can > >>> expose functions that need to be shared amoung files > >>> (without each one having lines and lines of 'extern foo' > >>> sillyness) without "leaking" them out anyplace > >>> else. > >>> > >> For example what about adding: > >> static APR_OPTIONAL_FN_TYPE(ap_proxy_lb_worker_size) > >> *proxy_lb_worker_size; > >> and use a void * in scoreboard and an int for the size? > > > > For me this sounds fine, but I would guess that Jim doesn't like > > the void * idea in the scoreboard. > > The scoreboard doesn't need to know what it stores ;-).
I agree with this. The void * solution (in fact we should not use a pointer there. We should use a non pointer type like an incomplete type or a char) also avoids wasting memory like we currently do with the fixed char array. Regards Rüdiger
